Change Assembly Version to AssemblyVersion in win_pe#4116
Change Assembly Version to AssemblyVersion in win_pe#4116alok1304 wants to merge 4 commits intoaboutcode-org:developfrom
Conversation
9cc045f to
51c9005
Compare
|
@pombredanne two test cases are failing when I used it shows (I checked for it shows that the I think no need to change this 'Assembly Version' to 'AssemblyVersion' because I think we should not handle the correct Windows PE versions when we using |
pombredanne
left a comment
There was a problem hiding this comment.
Both "Assembly Version" and "AssemblyVersion" exist in the wild. See the your updated tests that are skipping this value now.
This is not correct:
https://github.com/aboutcode-org/scancode-toolkit/pull/4116/files#diff-912e6b6b9ff4c33ea88d4f914e955f723fb024e17161592bfc2a2124718db218L5
You cannot replace one with the other, if need be you need both, if you can find a tiny test PE that actually contains "AssemblyVersion".
See https://github.com/search?q=["Assembly+Version"]+language%3AC%23&type=code
905a6cc to
9caa6b3
Compare
|
Hey @pombredanne
I use both "Assembly Version" and "AssemblyVersion" Now it is working and also all test cases are passed. |
|
@alok1304 see #4116 (review) you need to add a minimal test with a real example to test this functionality. Look for test files similar to what we have, do you need any help finding these? |
yes, I need help, how do we find these files for the test that contains AssemblyVersion? |
f46a156 to
c4a45eb
Compare
866cd81 to
abe6c8e
Compare
Reference: aboutcode-org#3790 Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
98021f0 to
33785a3
Compare
Fixes #3790
Tasks
Run tests locally to check for errors.
Signed-off-by: Alok Kumar alokkumarjipura9973@gmail.com